search

agra-uni-bremen / riscv-vp

RISC-V Virtual Prototype
MIT License
139 stars 49 forks source link

Question: AbstractUART #11

Open U2654 opened 3 years ago

U2654 commented 3 years ago

In the constructor of AbstractUART (line 54 of file), you set stop = false. I would suggest to set it the variable false after the treads are started? Or do I miss something?

Cirromulus commented 3 years ago

Would you like to have stop in an undefined state when threads are running?

U2654 commented 3 years ago

Sorry, you got me wrong. I did not mean initialising (which indeed should be in the c'tor) but setting its value inside the c'tor to true and after thread initialisation to false.