search

agra-uni-bremen / riscv-vp

RISC-V Virtual Prototype
MIT License
139 stars 49 forks source link

Submodule tests/integration not available publicly. #2

Closed vogelh0ws closed 4 years ago

vogelh0ws commented 4 years ago

Unfortunately the tests are only available on gitlab.informatik.uni-bremen.de which seems to be limited to university members.

Maybe they can be mirrored to GitHub. Until then, I removed the tests from the corresponding CMakeLists.txt.

nmeum commented 4 years ago

Hi, thanks for pointing this out. You are right, unfortunately the tests are not publicly available currently. How did you notice this in the first place? I just tried and it seems to me that the build passes successfully without checking out the integration tests submodule.

vogelh0ws commented 4 years ago

Of course, it's a very minor issue. Build works fine and the VP runs well. The README proposes to run "make test" which fails. I use the VP for teaching and I thought it would be nice if the README could just be followed.

nmeum commented 4 years ago

Ah, would removing (or rephrasing) the make test instruction from the README also work for you? The problem with removing the tests from the CMakeLists.txt is that we would no longer be able to run the tests internally.

vogelh0ws commented 4 years ago

Yes, of course!

nmeum commented 4 years ago

Alright, updated the README accordingly. The commit will be included in this GitHub repository next time we sync it with our private gitlab repo.