Unnecessary folders like test or tools are included while installing edge-js .

agracio / edge-js

Run .NET and Node.js code in-process on Windows, macOS, and Linux

MIT License

618 stars 93 forks source link

Unnecessary folders like test or tools are included while installing edge-js . #200

Closed PranithaSai closed 4 months ago

PranithaSai commented 4 months ago

Steps to reproduce:

Create a node-js project
run npm install edge-js command
folders like edge-js/test are included Are they really necessary?

agracio commented 4 months ago

Good point except for tools since install.js and associated scripts are located there. There is also stress, performance and samples. Will exclude them for next release.

PranithaSai commented 4 months ago

Good point except for tools since install.js and associated scripts are located there. There is also stress, performance and samples. Will exclude them for next release.

can we also exclude src locally (from node_modules/edge-js/src) if we only need the part of code that allows the .NET and node-js integration to work ( if we are installing the edge-js as dependancy )?

agracio commented 4 months ago

'src' is required for installing edge-js using npm i edge-js. While only parts of it are required on Windows both Linux and macOS require full source as it is rebuilt on npm i edge-js rather than using pre-built libraries that are under lib/native.

EDIT: locally you can exclude node_modules/edge-js/src, it is only required for npm i edge-js.

agracio commented 4 months ago

New version released. Removed all unnecessary files from package.