search

agracio / electron-edge-js

Run .NET and Node.js code in-process on Windows, MacOS, and Linux
MIT License
354 stars 92 forks source link

electron 13 #116

Closed camhart closed 3 years ago

camhart commented 3 years ago

electron 13

camhart commented 3 years ago

@agracio any chance we could get this merged and an update released?

gdavidkov commented 3 years ago

Hi, I've installed from your branch but I got the following error (node:24704) UnhandledPromiseRejectionWarning: Error: Module did not self-register: '\?\C:\Work\app\node_modules\electron-edge-js\lib\native\win32\x64\14.16.0\edge_nativeclr.node'. From package.json - "electron-edge-js": "git+https://github.com/camhart/electron-edge-js.git#master"

Electron 12 and 13 use the same Node version - 14.16.0. The build.bat should be fixed to support the same Node version for different Electron versions. @agracio Am I right?

camhart commented 3 years ago

@gdavidkov thanks for bringing this to my attention. I'll take a look at fixing it in the next few days.

Edit: You're welcome to put up a PR as well if you can get it done sooner.

Edit2: Since it's the same version of node.... does this lib even need updating...?

camhart commented 3 years ago

Since electron 13 uses the same version of node, I don't believe anything needs changed with this lib. Closing PR.