agracio / electron-edge-js

Run .NET and Node.js code in-process on Windows, MacOS, and Linux
MIT License
349 stars 91 forks source link

Electron 13 and Electron 12 #120

Closed gdavidkov closed 3 years ago

gdavidkov commented 3 years ago

Hi all, For the first time, Electron published a version with the same Node.js version - Electron 12 and 13 use Node.js 14.16.0, which lead to the necessity to rework how the module is built. I've changed the build.bat to support only Electron major versions - like 2.00 - 13.0.0. The output is saved in a folder named the Electron version. Therefore, we can have a pre-compiled module for every Electron version even with the same Node.js version. I've tested this PR with Electron 11,12 and 13 and works fine. I will be happy for any feedback.