Add support for Electron 29

agracio / electron-edge-js

Run .NET and Node.js code in-process on Windows, MacOS, and Linux

MIT License

354 stars 92 forks source link

Add support for Electron 29 #159

Closed ehellman closed 7 months ago

ehellman commented 7 months ago

Figured out how to build for newer Electron versions, however this is my first contribution to this repo and my first time building a new version so I'd suggest testing/verifying.

I used the x64 files in a electron@29.1.4 project and it worked successfully. Compiled with Node 20.9.0 but the project is using 20.11.1 without any issues.

agracio commented 7 months ago

Are you sure your referenced NodeJs version is correct, I cannot find any information that Electron 29 uses Node 20.9.0 headers

agracio commented 7 months ago

You are correct regarding Node.Js version, unfortunately there are multiple pages each giving different information about version. Package published to NPM.