search

agraef / pd-lua

Lua bindings for Pd, updated for Lua 5.3+
https://agraef.github.io/pd-lua/
GNU General Public License v2.0
47 stars 10 forks source link

fix installplus dep #31

Closed A1ca7raz closed 1 year ago

A1ca7raz commented 1 year ago

see https://github.com/agraef/pd-lua/issues/30

agraef commented 1 year ago

Sorry for getting back so late, I guess I overlooked your PR during busy times.

30 seems to arise because I assumed that the prerequisites of install in Makefile.pdlibbuilder would be made before the installplus requisite added in the Makefile. Which obviously isn't right, because the requisites can be made in any order, and even in parallel.

But your solution depends on these internal prerequisites in Makefile.pdlibbuilder, which might break due to upstream changes if Makefile.pdlibbuilder gets updated (which I do from time to time, by pulling the latest version from upstream).

I think that the proper solution would be to just add $(INSTALL_DIR) -v "$(installpath)" to installplus, i.e.:

installplus:
    $(INSTALL_DIR) -v "$(installpath)"
    cp -r ./pdlua/ "${installpath}"/pdlua

By these means there's only a single potential point of breakage, $(INSTALL_DIR), and that's unlikely to change.

Can you try whether that works for you and, if so, augment the PR accordingly? Thanks.

agraef commented 1 year ago

I've just added my proposed fix to the master branch, can you please test that it works for you? Then we can close this PR.