search

agraef / pd-lua

Lua bindings for Pd, updated for Lua 5.3+
https://agraef.github.io/pd-lua/
GNU General Public License v2.0
47 stars 10 forks source link

workflow: change dependencies for merging, clean-up #48

Closed ben-wes closed 4 weeks ago

ben-wes commented 4 weeks ago

as mentioned in https://github.com/agraef/pd-lua/pull/47#issuecomment-2308718438

this avoids merged artifacts to slip into the github release.

agraef commented 4 weeks ago

Ok, I have some doc fixes which warrant a new point release, so I can test this right away. :)

agraef commented 4 weeks ago

Hmm, the Deken upload didn't work. :( There are no actual packages on Deken, see http://deken.puredata.info/library/pdlua. And trying to install the 0.12.6 version gives me an error:

image

@ben-wes Help!

agraef commented 4 weeks ago

The log is also much shorter than the previous one. Looks like none of the artifacts were downloaded, so the upload was empty as well?

@ben-wes I have no idea how to fix this, so I'm afraid that I'll have to roll this back unless you can come up with a quick solution. :((

agraef commented 4 weeks ago

Also, it seems that the GH release now seems to have the artifacts that are supposed to be uploaded to Deken, but the GH artifacts are missing. What's going on there?

agraef commented 4 weeks ago

Looking at the workflow, I think that the download step is missing in deken-upload. I should be able to fix this myself.

ben-wes commented 4 weeks ago

ah. damn ... sorry - i was sure that i had tested this properly. can also have a look!

agraef commented 4 weeks ago

Well I committed a fix in rev. 665531f0fef80586c23462c1a7d356068326eb6f, which seems to work, but now the old, broken upload of 0.12.6 still shows on Deken as well:

image

Is there a way I can delete the broken package from Deken?

agraef commented 4 weeks ago

Here's how it looks like on the Deken website:

image

Note the broken package at the top. It doesn't seem that I can log into Deken to get rid of it?

agraef commented 4 weeks ago

Hmm, wait, that broken package is actually newer than the proper ones, so that must also have been part of the latest upload. There must still be something iffy in the deken upload action.

ben-wes commented 4 weeks ago

yes ... you can go to https://puredata.info/Members/agraef/software/pdlua/0.12.6/ and find all the files there. when you click on a file, you have this menu on the right:

image

the reason that this is happening is because of the source upload. and there are some redundancies now. i can fix this within a few minutes if ok for you! really sorry that i hadn't seen this. problem was that i continued from a state where i tried to make it more elegant ... and i should just have changed that dependency issue. anyway ... on it!

agraef commented 4 weeks ago

Yes, please do fix, as I don't really have the faintest idea what I'm doing. ;-) I'm going to get another cup of coffee in the meantime. Waiting as fast as I can...

agraef commented 4 weeks ago

yes ... you can go to https://puredata.info/Members/agraef/software/pdlua/0.12.6/ and find all the files there.

Thanks, I just got rid of the borked package. Now waiting for your proper fix. No sweat. :)

agraef commented 4 weeks ago

Should I revert my https://github.com/agraef/pd-lua/commit/665531f0fef80586c23462c1a7d356068326eb6f commit, or can you work from there?

ben-wes commented 4 weeks ago

Should I revert my 665531f commit, or can you work from there?

i rebased my stuff to that. all good with https://github.com/agraef/pd-lua/pull/49 i hope.

agraef commented 4 weeks ago

Well, I can tell that you're working on a Mac, because your #49 dropped a .github/.DS_Store file in there, lol. Can you please remove that?

agraef commented 4 weeks ago

Oh well, I guess that I can always remove the file in post.

ben-wes commented 4 weeks ago

no no, it's gone now after a force push. you should be able to merge now. that's embarrassing. m(

agraef commented 4 weeks ago

No worries, I noticed that you already fixed it. :) Thanks, mate! I really appreciate you doing a quick hotfix after my plea for help, on a lovely Sunday afternoon.

All looking good now:

image

agraef commented 4 weeks ago

BTW, now that 0.12.6 is done and dusted, would you mind reading over the new Signals and graphics tutorial section some time? Whenever you find the time. If you find any inaccuracies or errors, typos, etc., just let me know.

ben-wes commented 4 weeks ago

Thanks, mate! I really appreciate you doing a quick hotfix after my plea for help, on a lovely Sunday afternoon.

all good! - i mean, i created the mess in the first place. :)

BTW, now that 0.12.6 is done and dusted, would you mind reading over the new Signals and graphics tutorial section some time?

already read parts of it and really appreciate this! will read all new parts more carefully tonight and give feedback.