search

agraef / pd-lua

Lua bindings for Pd, updated for Lua 5.3+
https://agraef.github.io/pd-lua/
GNU General Public License v2.0
51 stars 11 forks source link

opening help files for gfx classes searches for `:gfx` suffixed classes #56

Closed ben-wes closed 1 month ago

ben-wes commented 1 month ago

i did a git bisect and found 23ee759e89f68ffacffd703241b0ad490eade40e to be the "bad commit".

when trying to open help files for gfx classes, pdlua will now search for class names with a :gfx suffix - like myobject:gfx-help.pd

ben-wes commented 1 month ago

more precisely, it's obviously this?

https://github.com/agraef/pd-lua/blob/master/pdlua.c#L1224

agraef commented 1 month ago

Yes, I needed to introduce the gfx shadow class since non-gui and gui objects need different widget behaviors, and these can only be set at the class level, not for each individual object. Live-coding lets you change a non-gui class to a gui one at a whim, so both classes need to be available for each .pd_lua script, and they can't be named the same.

Well spotted! Bonus points if you find a fix. :) There must be a function or callback somewhere which sets the help patch file name, that needs to be adjusted so that it's the same for both classes.

agraef commented 1 month ago

Fixed in rev. d56335e6a06c4048a9dcef822343be90c7e74290.

ben-wes commented 1 month ago

oh, nice. thanks for the fix! - looks so simple looking back, but wasn't obvious for me.