agrafix / Spock

Another Haskell web framework for rapid development
https://www.spock.li
679 stars 56 forks source link

Spock-core test failure with http-types 0.11 #138

Open DanBurton opened 6 years ago

DanBurton commented 6 years ago

As seen on the Stackage build server:

Failures:

  test/Web/Spock/Internal/CookiesSpec.hs:95:
  1) Generating Cookies, cookie value, should be urlencoded
       Failed to find "foo=most%2Bspecial%20chars%3B%25%D0%B1%D0%B8%D1%81%D0%BA%D0%B2%D0%B8%D1%82%D0%BA%D0%B8" in "foo=most%2bspecial%20chars%3b%25%d0%b1%d0%b8%d1%81%d0%ba%d0%b2%d0%b8%d1%82%d0%ba%d0%b8; Path=/"

Randomized with seed 312630884

Finished in 0.0068 seconds
56 examples, 1 failure

This is presumably due to the change as noted in the http-types changelog:

Remove dependency on blaze-builder. (Note that as a side effect of this, URI encoding is now using lower-case rather than uppercase hexadecimal.)

What is your take on the severity of this test failure? Do you think Stackage should hold back or move forward with http-types 0.11?

See also: https://github.com/fpco/stackage/issues/3226

aristidb commented 6 years ago

http-types 0.12 is released