search

agrafix / Spock

Another Haskell web framework for rapid development
https://www.spock.li
679 stars 56 forks source link

Improvements to GHA #174

Closed Zialus closed 2 years ago

Zialus commented 2 years ago

Currently there are still some problems with stackage and windows, specifically with the following versions:

More details here: https://github.com/agrafix/Spock/actions/runs/1838209684

Zialus commented 2 years ago

PR updated and first comment changed accordingly.

jberryman commented 2 years ago

Hey thanks for doing this! Do you want to have a stab at fixing the few errors we see? It would also be great to add ghc-9.2.3 as support should mostly be there (at least for Spock-core)

Zialus commented 2 years ago

I've added GHC 9.2.3

I'm not sure what to do about stack versions though, specially given this problem(https://github.com/orgs/community/discussions/15452) which means that we can't have experimental matrix options

@jberryman What do you think the best course of action should be?

jberryman commented 2 years ago

@Zialus I haven't looked into the particular issues you're wrestling with here, but I think it would be totally fine to simply comment out any sections that don't work right now, with a comment explaining why and what we might be able to do about it in the future if you have ideas. thanks again for revisiting this!

Zialus commented 2 years ago

@jberryman I'm cleaning up the commit history a bit, but the final state of the PR should be the one you see now.

jberryman commented 2 years ago

@Zialus amazing! Please ping me when you're happy with it

Zialus commented 2 years ago

@jberryman Everything should be good to go now 😄

jberryman commented 2 years ago

Thanks @Zialus this is a huge help!