search

agrajalesh / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

html #1

Open Axkaban opened 6 years ago

Axkaban commented 6 years ago

Thank you for the comments! https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/index.html#L11

Great job linking google fonts> https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/index.html#L5

Another option is adding it in the CSS file instead. You can use an @import like so: @import url("https://fonts.googleapis.com/css?family=Roboto:300,400,500,700,900" rel="stylesheet") at the top of the file.

great use of classes and good use of naming conventions. https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/index.html#L101-L102

agrajalesh commented 6 years ago

Pls can you explain me if Is it better to have the fonts in CSS file more than in html file?

Axkaban commented 6 years ago

Both of them are common practice, there is no specific preference that I am aware of, therefore none of them is better than the other.

agrajalesh commented 6 years ago

Ok thanks.

2018-02-08 9:54 GMT-05:00 Axel kaban notifications@github.com:

Both of them are common practice, there is no specific preference that I am aware of, therefore none of them is better than the other.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/issues/1#issuecomment-364136097, or mute the thread https://github.com/notifications/unsubscribe-auth/Af-9uFWnZULbu_kHzAY6MYthDU7xI3KPks5tSwqxgaJpZM4R8KDP .