agrajalesh / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

CSS #2

Closed Axkaban closed 6 years ago

Axkaban commented 6 years ago

Nice work implementing global styles: https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/resources/css/style.css#L1-L15

Thanks again for comments: https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/resources/css/style.css#L16

Very interesting approach with the media queries: https://github.com/agrajalesh/f1-3-c2p1-colmar-academy/blob/master/colmar%20academy%20project/resources/css/style.css#L81

it seems that is necessary to establish fixed measurements like px instead of responsive ones like ems. When I play with inspect on mobile sizes, the menu icons didn't show up, like when I shrink browser, and the regular text letters go bananas! screen shot 2018-02-07 at 12 10 17 am I really believe that it is because of the intent for responsiveness in media queries. No big deal though. Just no mobile visibility

agrajalesh commented 6 years ago

Ok Thanks. I will check it.