search

agrastiOs / Ultimate-TF2-Visual-Fix-Pack

A pack of visual fixes for TF2, to be sent to Valve.
178 stars 14 forks source link

Causes TF2 to crash upon joining `sv_pure` servers #49

Closed Tkain closed 1 month ago

Tkain commented 3 years ago

I've been having this issue for a long time where installing the Ultimate TF2 Visual Fix Pack causes the game to crash when joining some servers (most notably, many of the Valve and Skial ones). Interestingly, it only crashes the game sometimes, although if the game crashes on a server when it's first joined, it's likely to keep crashing for a while if you keep trying to rejoin that server. The crashing doesn't occur when the fixes are removed.

I'm currently going through the files in groups to see which ones, if any of them specifically, are causing the crash.

agrastiOs commented 3 years ago

Thanks, most likely it is the issue with the sv_pure system being susceptible to crashes on the model side.

Tkain commented 3 years ago

Yeah, it's almost certainly an sv_pure issue, especially seeing as how this has occurred to me on Valve servers as well as Skial ones. I've been able to deduce the offending models as the C-models for the Sniper Rifle (weapons/c_models/c_sniperrifle) and the Crusader's Crossbow (workshop/weapons/c_models/c_crusaders_crossbow) - after taking those ones out, I haven't had crashes since.

Of course, the most ideal fix would be to get Valve to fix whatever code bug is causing these crashes since they don't occur on non-sv_pure servers, but for now, taking those models out should work as a workaround.

agrastiOs commented 2 years ago

I can confirm that the aforementioned workaround works. There are some plans that would also incidentally allow everyone to do this workaround quick in a future release.

Excalibur624 commented 2 years ago

An update on this situation: It seems c_skullbat_skeleton.vmt is another culprit of the crashing since the Scream Fortress update. I'll update if there's any more I can find

agrastiOs commented 2 years ago

Huh, are you sure? That is not a model but just a material.

Excalibur624 commented 2 years ago

Yeah, I know that. In the Scream Fortress update Valve updated the materials for the Bat Outta Hell, and the ones from this pack seemed to conflict with it on sv_pure servers. I was crashing even after removing the crossbow and sniper rifle C models, and deleting the skullbat material seemed to have fixed it. Unless it was just a freak thing on my end, but I haven't crashed since

agrastiOs commented 2 years ago

Please see the latest release for a workaround to the problem.

agrastiOs commented 2 years ago

Yeah, I know that. In the Scream Fortress update Valve updated the materials for the Bat Outta Hell, and the ones from this pack seemed to conflict with it on sv_pure servers. I was crashing even after removing the crossbow and sniper rifle C models, and deleting the skullbat material seemed to have fixed it. Unless it was just a freak thing on my end, but I haven't crashed since

Can't see that to be the case.

agrastiOs commented 1 month ago

As this is not a bug in our side, closing.