agrc / DEQ-TankRisk

An ArcGIS Pro toolbox for DEQ to assess the risk of underground storage tanks
MIT License
1 stars 0 forks source link

Output files overwritten #18

Closed nathankota closed 4 years ago

nathankota commented 4 years ago

Output folder contents are overwritten each time the tool is run. Successive tool runs should keep previous outputs and add new results.

steveoh commented 4 years ago

the current work around for this is to choose a separate folder for the output

steveoh commented 4 years ago

I'm not sure how this is happening because https://github.com/agrc/DEQ-TankRisk/blob/03d1e6b3cbfa2b8d602c65fab1ab4658867692d0/src/tank_risk.py#L90-L94 generates unique folder names based on a time string which is unique every second.

I also cannot reproduce. Is this something the client is experiencing?

image

nathankota commented 4 years ago

Yes, client is experiencing. Further client testing of this has been requested, using a different output location.

steveoh commented 4 years ago

It appears that pro deletes the contents of the folder on each run. What do you suggest we do here?

nathankota commented 4 years ago

Maybe it becomes part of their workflow to transfer and save output files to a different directory. I'll discuss with DEQ.