soilSev and shallowWaterSev are not calculating

[nathankota]

I was looking at the soilSev values for both the old data and new and it appears that the code isn't picking out the criteria for a long time (everything is zero)...there is an issue with the Groundwater/shallowWaterSev value too.

Rick found some old rules in a spreadsheet from long ago, but I wasn't able to find the rules in the code to check them against the following (note: the layer and attribute names are wrong below, but the values should be the same).

soilSev

WHEN value LIKE '%gravel%' THEN 5
WHEN value LIKE '%cobb%' THEN 5
WHEN value LIKE '%ston%' THEN 5
WHEN value LIKE '%frag%' THEN 5
WHEN value LIKE '%bould%' THEN 5
WHEN value LIKE '' THEN 5
WHEN value LIKE '%sand%' THEN 4
WHEN value LIKE '%flag%' THEN 3
WHEN value LIKE '%channer%' THEN 3
WHEN value LIKE '%varia%' THEN 3
WHEN value = 'loam' THEN 3
WHEN value LIKE '%silt%' THEN 2
WHEN value LIKE '%plant%' THEN 2
WHEN value LIKE '%pea%' THEN 2
WHEN value LIKE '%clay%' THEN 1
WHEN value LIKE '%bedr%' THEN 1
ELSE 1000 END AS TextureScore

shallowWaterSev

WHEN value
DEPTH = 0 THEN 5 
WHEN value
DEPTH = 10 THEN 2.5 
WHEN value.DEPTH = 30 THEN 1 
ELSE 0

[steveoh]

Are these values consistent with the new soil attributes or does there need to be modifications @nathankota ?

These are all of the possibilities

ashy loam
bedrock
bouldery loam
bouldery sandy loam
channery clay loam
channery fine sandy loam
channery loam
channery sandy clay loam
channery sandy loam
channery silt loam
channery silty clay loam
clay
clay loam
coarse, gypsum, material
coarse sandy loam
cobbly clay loam
cobbly coarse sandy loam
cobbly fine sandy loam
cobbly loam
cobbly loamy fine sand
cobbly loamy sand
cobbly sandy loam
cobbly silt loam
cobbly silty clay loam
cobbly very fine sandy loam
extremely bouldery fine sandy loam
extremely bouldery loam
extremely bouldery sandy loam
extremely bouldery silt loam
extremely channery clay loam
extremely channery loam
extremely channery sandy loam
extremely channery silty clay loam
extremely cobbly clay loam
extremely cobbly coarse sandy loam
extremely cobbly loam
extremely cobbly loamy coarse sand
extremely cobbly loamy sand
extremely cobbly sandy clay loam
extremely cobbly sandy loam
extremely cobbly very fine sandy loam
extremely flaggy fine sandy loam
extremely flaggy loam
extremely gravelly fine sandy loam
extremely gravelly loam
extremely gravelly loamy fine sand
extremely gravelly sand
extremely gravelly sandy loam
extremely stony clay loam
extremely stony coarse sandy loam
extremely stony fine sandy loam
extremely stony loam
extremely stony loamy sand
extremely stony sandy loam
extremely stony very fine sand
fine gravelly loam
fine sand
fine sandy loam
flaggy clay loam
flaggy loam
gravelly ashy loam
gravelly ashy sandy loam
gravelly clay
gravelly clay loam
gravelly coarse sand
gravelly coarse sandy loam
gravelly fine sandy loam
gravelly loam
gravelly loamy fine sand
gravelly loamy sand
gravelly sand
gravelly sandy clay loam
gravelly sandy loam
gravelly silt loam
gravelly silty clay
gravelly silty clay loam
gravelly very fine sandy loam
gypsiferous silt loam
loam
loamy coarse sand
loamy fine sand
loamy sand
loamy very fine sand
mucky peat
parachannery loam
parachannery silt loam
parachannery silty clay loam
peat
peaty silt loam
sand
sandy clay loam
sandy loam
shaly clay loam
shaly loam
silt loam
silty clay
silty clay loam
stones
stony clay loam
stony fine sandy loam
stony loam
stony sandy loam
stony silt loam
stratified cobbly sand to sand to fine sandy loam
stratified fine sandy loam to extremely gravelly sand
stratified fine sandy loam to silty clay
stratified gravelly coarse sand to cobbly sandy loam
stratified gravelly sand to sand to fine sandy loam
stratified sand to extremely gravelly sand
stratified silty clay loam to silt loam to sand
stratified silty clay loam to silt loam to very fine sand
stratified silty clay to silt loam to very fine sand
variable
very bouldery fine sandy loam
very bouldery loam
very bouldery sandy loam
very channery clay loam
very channery fine sandy loam
very channery loam
very channery loamy sand
very channery sandy clay loam
very channery sandy loam
very channery silt loam
very cobbly clay loam
very cobbly coarse sandy loam
very cobbly fine sand
very cobbly fine sandy loam
very cobbly loam
very cobbly loamy fine sand
very cobbly loamy sand
very cobbly sandy clay loam
very cobbly sandy loam
very cobbly silt loam
very cobbly silty clay loam
very cobbly very fine sandy loam
very fine sand
very fine sandy loam
very flaggy fine sandy loam
very flaggy loam
very flaggy silt loam
very gravelly ashy loam
very gravelly ashy sandy clay loam
very gravelly clay loam
very gravelly coarse sandy loam
very gravelly fine sandy loam
very gravelly loam
very gravelly loamy fine sand
very gravelly loamy sand
very gravelly sandy clay loam
very gravelly sandy loam
very gravelly silt loam
very gravelly very fine sandy loam
very parachannery clay loam
very parachannery gypsiferous silty clay loam
very parachannery silty clay
very stony clay
very stony clay loam
very stony fine sandy loam
very stony loam
very stony loamy fine sand
very stony sandy clay loam
very stony sandy loam
very stony silt loam
very stony silty clay loam
very stony very fine sandy loam
weathered bedrock

Of these %frag% and %plant% don't match anything and ashy loam, coarse, gypsum, material, and shaly loam aren't caught by any of the options.

[rsaathoff]

shaly loam = 2 ashy loam = 3 course = 5 gypsum = 2 material = 5

[steveoh]

coarse, gypsum, material is one entry. So it needs one score. You have 5 and 2. You'll need to pick one @rsaathoff

[rsaathoff]

coarse, gypsum, material = 5

[steveoh]

Great. That is what I guessed.

Please review the changes and let comment if it looks good.

https://github.com/agrc/DEQ-TankRisk/pull/30/files#diff-86229c74252a236decfc59fcb3251cb48893ec2e2dd86a24563a6e9498c4fde9R270-R303

[rsaathoff]

That looks correct