agrc / deq-enviro

DEQ Environmental Data Viewer
MIT License
6 stars 1 forks source link

Advanced Searches #537

Closed stdavis closed 1 year ago

stdavis commented 1 year ago
nathankota commented 1 year ago

Seeing some different results for identical queries b/t prod and dev.

Layers searched

DDW: GWPZ DAQ: Oil & Gas Wells and Air Monitoring by Station DERR: Water Rights POD DAQ: Air Monitoring Stations

County Test

Juab

Prod app results

image

Dev app results

image

Beaver

Prod

image

Dev

image

City test

Price

Prod

image

Dev

image

Zip test

84106

Prod

image

Dev

image

Street address

4315 S 2700 W, Taylorsville; buffer = 3 miles

Prod

image

Dev

image

ID

4304530005 (Oil and Gas Wells)

Results were the same, but the dev app zoomed way father in than prod, and I had to zoom out to see where the point was. Matching the zoom level for single returned points with prod might be worth a try.

Prod

image

Dev

image

06009WS001 (Groundwater Protection Zones)

Prod

image

Dev

NO RESULTS

Shape

Polygon (in about the same area)

Results were different

Other Shape search comments

NHD Stream Name

Results were different for each test query, but the searched stream names went to the same location, which is good.

Little Cottonwood Creek (Salt Lake)

Prod

image

Dev

image

Coordinates

UTM 463089.1, 4195327.42, 1 mile buffer

Prod

image

Dev

image

Degrees minutes seconds

stdavis commented 1 year ago

@nathankota This issue is ready for another look in staging.

I focusing on getting the results in the new app to match what Pro showed me for the same data. I didn't spend time trying to figure out why the old app differed.

This feedback was invaluable as it pointed me to some bad assumptions in how I was searching in the new app. I feel far more confident in the results now.

Points of Diversion

Search: Juab County (9/8/2023) New App: 5454 Old App: 3603

Queries in Pro: Image

New App after bb0a992498bb4cc9ab8c9869cdd4f235ef9b23f3: 5457

Ground Water Protection Zones

Search: Juab County (9/19/2023) New App: 99 Old App: 144

Queries in Pro: image

New App after 88303030c54ff3f234f7347cf29e8f24c4e9b103: 149

Shape

Is it correct that only polygon search areas can be created?

Yes, for now. This was an oversight on my part. Let me know if you want me to add the missing functionality or wait for them to ask for it.

Not sure what the purpose of the arrow (Select feature) or the back and forward arrows are on the toolbar. They don't seem to do anything, and the back/forward arrows are never activated on the toolbar.

These are default controls for undo/redo during drawing. They seem to be working for me. Let me know if you think that we should just remove them.

Zoom Levels

Results were the same, but the dev app zoomed way father in than prod, and I had to zoom out to see where the point was. Matching the zoom level for single returned points with prod might be worth a try.

I set the max zoom level to 17 which should prevent a blank map. This is zoomed in a little further than prod but I think that it will be useful for features that are not in the middle of the Great Salt Lake. :)

Address Buffer

I didn't have a great way of testing this since I couldn't reproduce the exact same buffer in Pro. image

This is the buffer function that I'm using in the app after projecting the point to UTM: https://developers.arcgis.com/javascript/latest/api-reference/esri-geometry-geometryEngine.html#buffer

Coordinates

DMS did not zoom to the same location in prod and dev (see below)

This was a bug that I fixed.

I like how the prod app assumes negative for longitude, rather than having to enter the negate operator on the dev app

I updated the app to assume negative for longitude and also added the suffix symbols similar to the old app.

nathankota commented 1 year ago

I've done some additional testing and I'm ready to close this down as it is, and we can accumulate feedback from the DEQ testing team for any new issues.