agrc / forklift

:tractor::package::sparkles: Slinging data all over the place :tractor::package::sparkles:
MIT License
28 stars 3 forks source link

Allow shipping of pallets that did not lift 100% successfully #294

Closed stdavis closed 5 years ago

stdavis commented 5 years ago

Hypothetical steps to reproduce

Lift the AGOL pallet. One layer has an issue and does not lift successfully but there are others that update successfully.

Expected behavior

During ship, crates that updated successfully would be processed. Despite others having errors.

Actual behavior

This code block prevents any of the crates from the pallet from shipping. After fixing the problem, the updates for the successful crates would not be pushed to AGOL until the data is updated again in the future.

I wonder if we could just get rid of the success check? Or perhaps this is an issue with how the AGOL pallet is written?