search

agrc / forklift

:tractor::package::sparkles: Slinging data all over the place :tractor::package::sparkles:
MIT License
28 stars 3 forks source link

feat: ability to send lift report to slack #313

Closed steveoh closed 4 years ago

steveoh commented 4 years ago

Description of Changes

lets you send the lift report to slack

need to add a slackWebhookUrl to the config. I'll send you ours if you want to try it.

refs #306

Name                                        Stmts   Miss Branch BrPart     Cover   Missing
------------------------------------------------------------------------------------------
C:\dev\forklift\src\forklift\arcgis.py        113     29     32      2    70.34%   26, 79-107, 137-138, 143, 146, 163, 181, 198-200, 222-224, 178->181, 197->198
C:\dev\forklift\src\forklift\config.py         50      1     20      2    95.71%   82, 81->82, 117->116
C:\dev\forklift\src\forklift\core.py          186      5     72      3    96.12%   122, 145-146, 345, 415, 121->122, 292->291, 414->415
C:\dev\forklift\src\forklift\engine.py        464    162    156     12    62.58%   135, 205, 218, 231-308, 323-325, 348-349, 387-458, 488, 498, 512-528, 533-546, 562, 582, 601, 614-617, 671-678, 708-709, 714, 728-734, 740, 747, 793, 898-938, 132->135, 217->218, 230->231, 312->358, 322->323, 561->562, 600->601, 668->671, 705->708, 711->714, 744->747, 792->793
C:\dev\forklift\src\forklift\lift.py          145     51     52      4    60.91%   39, 149-152, 159-160, 183-194, 229-250, 277, 281, 288-291, 306-313, 342-353, 38->39, 148->149, 155->159, 280->281
C:\dev\forklift\src\forklift\messaging.py      53     10     16      1    72.46%   58, 79, 100-112, 78->79
C:\dev\forklift\src\forklift\models.py        192      4     56      3    96.37%   89, 392, 444-445, 176->175, 389->392, 436->444
C:\dev\forklift\src\forklift\slack.py         211     33    100     32    75.88%   25-27, 57, 72-77, 80-85, 101, 103, 105, 117-118, 137, 161-164, 236, 261, 266, 280, 289, 306, 333, 335, 349, 361, 373, 376, 24->25, 54->57, 71->72, 79->80, 90->93, 100->101, 102->103, 104->105, 111->114, 116->117, 120->87, 134->137, 151->184, 155->158, 160->161, 168->171, 174->177, 189->192, 195->197, 197->200, 202->205, 260->261, 277->279, 279->280, 285->288, 288->289, 305->306, 332->333, 334->335, 348->349, 352->355, 355->358
------------------------------------------------------------------------------------------
TOTAL                                        1436    295    510     59    75.95%

3 files skipped due to complete coverage.

================== 156 passed, 94 skipped in 130.88 seconds ===================
stdavis commented 4 years ago
stdavis commented 4 years ago

This is super-cool!

steveoh commented 4 years ago

I was thinking it shouldn't be added by default since it's a niche property.

stdavis commented 4 years ago

OK. I can see that. Docs would be enough.

steveoh commented 4 years ago

Do you want to give this a shot on the test server or the wri server or should I add the ship report and all the rest? What would you like to see done before merging?

stdavis commented 4 years ago

I'm good with merging it now and adding the ship report later if you'd like.

stdavis commented 4 years ago

Do you want to give this a try on WRI or something smaller?

steveoh commented 4 years ago

yup, wri should be fine.

stdavis commented 4 years ago

I've got this set up on the WRI server. 🤞

stdavis commented 4 years ago

I wonder if there's a way to post a link to the log file? Not sure where we would stick it. Maybe GCP?

steveoh commented 4 years ago

There is a files block type we could look into and it requires the file to be available remotely.

stdavis commented 4 years ago

I installed the latest from the slack branch on the server.