agrc / forklift

:tractor::package::sparkles: Slinging data all over the place :tractor::package::sparkles:
MIT License
28 stars 3 forks source link

Proposal: Incorporate SGID.META.ChangeDetection for SGID-based crates #317

Closed stdavis closed 4 years ago

stdavis commented 4 years ago

For crates with sources in SGID (internal) we should take advantage of https://github.com/steveoh/cambiador and use the hashes in SGID.META.ChangeDetection rather than hashing the source data.

Proposed implementation steps

~- [ ] Extend models.Changes to allow for modeling change without specifying adds or deletes.~

Additional questions to answer

stdavis commented 4 years ago

@steveoh Are you open enough to this proposal that it would be worth my time opening a PR?

steveoh commented 4 years ago

I wonder if this is over complicated. Let's chat in slack