search

agrc / gis.utah.gov

The official UGRC website
https://gis.utah.gov
MIT License
25 stars 40 forks source link

SGID Index Validation Issues #2760

Open github-actions[bot] opened 1 month ago

github-actions[bot] commented 1 month ago

Validation errors have been detected in the SGID Index. This issue will be used to track the resolution of these issues.

GitHub Actions should post a comment with the details shortly...

To rerun the validation script, add a new comment that starts with the following text: /validate-sgid-index.

github-actions[bot] commented 1 month ago

SGID Index Validation

2024-07-15 19:09:51

Script Output

using ci credentials
loading spreadsheet
building duplicate lookups
checking 530 rows

total errors: 9
updated 8 rows

Validation Errors

displayName id Error
Licensed Health Care Facilities a58d176f-5c95-4a45-b8e8-c544aa3b845a downloadMetadata(Utah Licensed Health Care Facilities): "featureServiceId" does not match SGID Index column "serverServiceName"
Pony Express 1f62a035-edf1-436a-869b-6c280fe5253c No "productPage" or "itemId"
SMS Safety Index 8d8c0e70-9989-4527-af42-49d57f86a7f7 No "productPage" or "itemId"
SMS Severe Crashes Per Mile d7f54d25-8781-4162-8666-690b3eb6688a No "productPage" or "itemId"
State Boundary Snap Points 6c80a6ba-8202-411f-b5f0-abb9905ecef3 No "productPage" or "itemId"
State Fuel Sites 98701ae5-df6c-44dc-a4c8-c37350b4ced0 downloadMetadata(Utah State Fuel Sites): "openSgid" does not match SGID Index column "openSgidTableName"
State Fuel Sites 98701ae5-df6c-44dc-a4c8-c37350b4ced0 "society.state_fuel_sites" Open SGID table not found
UHP Dispatch 3af36877-8bd8-4a0a-bb03-a43ad8b76fea No "productPage" or "itemId"
Watershed Restoration Initiative Treatment Areas bfa1fa62-19b9-4315-aad1-54a23cb7968e No "productPage" or "itemId"
stdavis commented 1 month ago

/validate-sgid-index

stdavis commented 1 month ago

/validate-sgid-index

steveoh commented 2 weeks ago

/validate-sgid-index

jacobdadams commented 2 weeks ago

For the NFHL one, I'm not sure why it's giving a 404 error. That is the right itemID for the flood hazard area layer. Is it because it's hosted in DEM's org? https://utah-em.maps.arcgis.com/home/item.html?id=b2c606f13a4c4a59b3c253647883833f

stdavis commented 2 weeks ago

@jacobdadams Do you know if that item is shared a hub? This is the request that the validation script is attempting to make:

https://opendata.arcgis.com/api/v3/datasets/833d52f3-ad52-499f-a95e-64fcdf84a956_49

It returns 403 - forbidden.

jacobdadams commented 2 weeks ago

It does not look like it, no. While they have a hub site, they don't really have an open data portal in it. I wonder if we should explore having them share it to one of our SGID groups so that it shows up in ours?

stdavis commented 2 weeks ago

Hub does seem to be a requirement for the validation script. I'm not sure if that was intended or not. We do seem to default to sharing links to hub over AGOL. Perhaps because it is more targeted to a more universal audience.

jacobdadams commented 2 weeks ago

So is that in effect saying that if the SGID index references an AGOL item, it needs to be shared via hub?

stdavis commented 2 weeks ago

So is that in effect saying that if the SGID index references an AGOL item, it needs to be shared via hub?

That's the way that the validation script is written. I don't remember if that is an official decision that has been made. @steveoh ?

steveoh commented 2 weeks ago

it needs to be shared via hub?

This is most likely a product of our testing data. Since most of the items are shared via Hub, that was the route we took for validation. I guess we'll need to rethink this a bit.

The sgid index sheet is designed around hub with the schema and this isn't a hub item. We could add the AGOL item urls to the product URL and skip the hub stuff... I'd have to take a minute to think this through a bit more as I'm not sure all of the side effects.

gregbunce commented 2 weeks ago

after reaching out to udot, i was able to update/remove the records they steward.

@steveoh or @stdavis can we run the validation again to see where we stand?

steveoh commented 2 weeks ago

/validate-sgid-index

I just added environment.dwmrc_solid_waste_facilities to the solid waste one to fix the first error.

The wri cert should be valid now.

gregbunce commented 2 weeks ago

/validate-sgid-index

steveoh commented 5 days ago

@rkelson you'll need to update the sgid index sheet to reflect these changes. That record is missing some other fields as well that could be populated from my quick glance.

displayName id Error
State Fuel Sites 98701ae5-df6c-44dc-a4c8-c37350b4ced0 "society.state_fuel_sites" Open SGID table not found

@ZachBeck if you started the deprecation process of the health stuff, please update the sgid index sheet as well.

displayName id Error
Health Care Facilities 1e0b5206-7e02-4980-b3a9-9341f3698fd6 "health.health_care_facilities" Open SGID table not found