agrc / gis.utah.gov

The official UGRC website
https://gis.utah.gov
MIT License
25 stars 41 forks source link

fix(validation): validate that hub slugs match the names #2818

Closed stdavis closed 2 months ago

stdavis commented 2 months ago

This finds issues such as slugs being appended with "-1" and breaking links from our website to hub.

Here are a few examples of the errors that it found during testing today:

|UREZ Phase 1 Solar Zones|666f6286-d7bf-43a0-9cd8-a713edd9c671|slug: "utah::utah-urez-phase-1-solar-zones-1" does not match hub name: "Utah UREZ Phase 1 Solar Zones". You may need to temporarily rename the item in Hub and then change it back to fix the slug|
|Utah Major Lakes|f3e70f49-8623-4d66-b3b2-32d777db5409|slug: "utah::utah-major-lakes-1" does not match hub name: "Utah Major Lakes". You may need to temporarily rename the item in Hub and then change it back to fix the slug|
|Watershed Restoration Initiative Treatment Areas|bfa1fa62-19b9-4315-aad1-54a23cb7968e|No "productPage" or "itemId"|
|Watersheds Area|619433b6-cdf7-4267-8a2a-3a4436a3eeac|slug: "utah::utah-watersheds-area-1" does not match hub name: "Utah Watersheds Area". You may need to temporarily rename the item in Hub and then change it back to fix the slug|
netlify[bot] commented 2 months ago

Deploy Preview for gis-utah-gov ready!

Name Link
Latest commit e63a5e57f4d586b7612acdc6bf6acc00459b8a98
Latest deploy log https://app.netlify.com/sites/gis-utah-gov/deploys/66ba5cbfc94db2000815252f
Deploy Preview https://deploy-preview-2818--gis-utah-gov.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 97 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

steveoh commented 2 months ago

What do you think about doing the rename fix here eventually?

stdavis commented 2 months ago

What do you think about doing the rename fix here eventually?

That would be cool. Do they have an api for that?