agrc / masquerade

Disguise UGRC's Web API endpoints as an Esri locator service.
https://github.com/agrc/masquerade#readme
MIT License
1 stars 0 forks source link

fix: cleanse inputs that may have issues #127

Closed stdavis closed 1 year ago

stdavis commented 1 year ago

Closes #124

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 67.64% and project coverage change: -0.17 :warning:

Comparison is base (bfd45ed) 85.39% compared to head (862d387) 85.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## ========================================== - Coverage 85.39% 85.23% -0.17% ========================================== Files 3 4 +1 Lines 315 325 +10 Branches 33 36 +3 ========================================== + Hits 269 277 +8 - Misses 40 43 +3 + Partials 6 5 -1 ``` | [Impacted Files](https://app.codecov.io/gh/agrc/masquerade/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc) | Coverage Δ | | |---|---|---| | [src/masquerade/main.py](https://app.codecov.io/gh/agrc/masquerade/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL21hc3F1ZXJhZGUvbWFpbi5weQ==) | `66.98% <25.00%> (-1.02%)` | :arrow_down: | | [src/masquerade/providers/open\_sgid.py](https://app.codecov.io/gh/agrc/masquerade/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL21hc3F1ZXJhZGUvcHJvdmlkZXJzL29wZW5fc2dpZC5weQ==) | `95.71% <87.50%> (+1.38%)` | :arrow_up: | | [src/masquerade/providers/web\_api.py](https://app.codecov.io/gh/agrc/masquerade/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL21hc3F1ZXJhZGUvcHJvdmlkZXJzL3dlYl9hcGkucHk=) | `90.78% <100.00%> (-1.11%)` | :arrow_down: | | [src/masquerade/utils.py](https://app.codecov.io/gh/agrc/masquerade/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL21hc3F1ZXJhZGUvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stdavis commented 1 year ago

i wonder if we'd want any of the other api client type of replacements added here?

I feel like we looked at re-implementing those in this project and decided that it was best to keep them in one place. But I'm open to different thoughts on it for sure.