search

agrc / palletjack

A library for updating AGOL data from various external sources
https://agrc.github.io/palletjack/palletjack/
MIT License
12 stars 0 forks source link

Improvements and fixes to attachment downloading from Google Drive/updating AGOL attachments #12

Closed jacobdadams closed 2 years ago

jacobdadams commented 2 years ago

Some changes I found while I wrote the UORG skid. These bring the use of that datapath more in line with the others (loader methods return a dataframe, updater methods consume a dataframe).

codecov[bot] commented 2 years ago

Codecov Report

Merging #12 (0fb8b4e) into main (c61cfe7) will decrease coverage by 2.26%. The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   85.88%   83.61%   -2.27%     
==========================================
  Files           3        4       +1     
  Lines         340      409      +69     
  Branches       50       56       +6     
==========================================
+ Hits          292      342      +50     
- Misses         46       65      +19     
  Partials        2        2
Impacted Files Coverage Δ
src/palletjack/testing.py 0.00% <0.00%> (ø)
src/palletjack/loaders.py 77.85% <58.97%> (-7.75%) :arrow_down:
src/palletjack/updaters.py 88.18% <97.36%> (+2.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c61cfe7...0fb8b4e. Read the comment docs.

jacobdadams commented 2 years ago

I'm ok with the coverage for right now- I think it's failing because of some WIP stuff that isn't finished and thus isn't tested.