agrc / palletjack

A library for updating AGOL data from various external sources
https://agrc.github.io/palletjack/palletjack/
MIT License
12 stars 0 forks source link

feat: use Google API to download files #21

Closed jacobdadams closed 1 year ago

jacobdadams commented 1 year ago

Use the Google API to download files instead of anonymous HTTP requests (but still leave the old code... will probably deprecate in v3).

Google will block your anonymous requests after a certain amount of time, so this provides a more reliable way to download files.

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.88% // Head: 91.99% // Increases project coverage by +3.10% :tada:

Coverage data is based on head (a289aab) compared to base (91038a6). Patch coverage: 98.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #21 +/- ## ========================================== + Coverage 88.88% 91.99% +3.10% ========================================== Files 6 6 Lines 621 662 +41 Branches 88 93 +5 ========================================== + Hits 552 609 +57 + Misses 65 49 -16 Partials 4 4 ``` | [Impacted Files](https://codecov.io/gh/agrc/palletjack/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc) | Coverage Δ | | |---|---|---| | [src/palletjack/updaters.py](https://codecov.io/gh/agrc/palletjack/pull/21/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svdXBkYXRlcnMucHk=) | `91.66% <ø> (ø)` | | | [src/palletjack/loaders.py](https://codecov.io/gh/agrc/palletjack/pull/21/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svbG9hZGVycy5weQ==) | `90.55% <97.43%> (+12.55%)` | :arrow_up: | | [src/palletjack/utils.py](https://codecov.io/gh/agrc/palletjack/pull/21/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svdXRpbHMucHk=) | `95.23% <100.00%> (+0.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jacobdadams commented 1 year ago

Will also close #11