agrc / palletjack

A library for updating AGOL data from various external sources
https://agrc.github.io/palletjack/palletjack/
MIT License
12 stars 0 forks source link

Implement Postgres Loader #30

Closed stdavis closed 1 year ago

stdavis commented 1 year ago

This pull requests adds a new Postgres loader and fixes a few issues encountered along the way.

I'm not sure why all of these tests were failing for me. I wondered if the arcgis package updated their Feature Layer class. Maybe that was a breaking change at v2?

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.99% // Head: 91.99% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (58a730e) compared to base (f9a0e79). Patch coverage: 93.54% of modified lines in pull request are covered.

:exclamation: Current head 58a730e differs from pull request most recent head 115a670. Consider uploading reports for the commit 115a670 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## ======================================= Coverage 91.99% 91.99% ======================================= Files 6 6 Lines 662 687 +25 Branches 93 91 -2 ======================================= + Hits 609 632 +23 - Misses 49 50 +1 - Partials 4 5 +1 ``` | [Impacted Files](https://codecov.io/gh/agrc/palletjack/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc) | Coverage Δ | | |---|---|---| | [src/palletjack/loaders.py](https://codecov.io/gh/agrc/palletjack/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svbG9hZGVycy5weQ==) | `90.25% <86.66%> (-0.30%)` | :arrow_down: | | [src/palletjack/\_\_init\_\_.py](https://codecov.io/gh/agrc/palletjack/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/palletjack/updaters.py](https://codecov.io/gh/agrc/palletjack/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svdXBkYXRlcnMucHk=) | `91.66% <100.00%> (ø)` | | | [src/palletjack/utils.py](https://codecov.io/gh/agrc/palletjack/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svdXRpbHMucHk=) | `95.58% <100.00%> (+0.35%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.