agrc / palletjack

A library for updating AGOL data from various external sources
https://agrc.github.io/palletjack/palletjack/
MIT License
12 stars 0 forks source link

move agol column renaming to transform, add a check #36

Closed jacobdadams closed 1 year ago

jacobdadams commented 1 year ago

load.FeatureServiceUpdater and transform.APIGeocoder.geocode_dataframe() both call utils.rename_columns_for_agol(). This should be moved to transform, possibly under DataCleaning. The geocoder and updater should just be concerned with updating, leaving any modifications to an earlier step.

In doing so, we should have a utils.FieldChecker method for verifying field names are valid AGOL names... except maybe this is already covered by 'check_fields_present`?

jacobdadams commented 1 year ago

fixed by b96701b5