agrc / palletjack

A library for updating AGOL data from various external sources
MIT License
12 stars 0 forks source link

Thousands #51

Closed jacobdadams closed 11 months ago

jacobdadams commented 12 months ago

Better handling string values in the to_nullable_int and to_float transform methods.

Uses locale, but relies on client to set localization per docs. However, most people probably don't think about this, so if locale.LC_NUMERIC isn't set, it sets it to the system default.

Closes #50

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 94.44% and project coverage change: +0.21 :tada:

Comparison is base (e815d4b) 90.51% compared to head (b0477ee) 90.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 90.51% 90.73% +0.21% ========================================== Files 7 7 Lines 886 896 +10 Branches 126 127 +1 ========================================== + Hits 802 813 +11 + Misses 76 74 -2 - Partials 8 9 +1 ``` | [Impacted Files](https://app.codecov.io/gh/agrc/palletjack/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc) | Coverage Δ | | |---|---|---| | [src/palletjack/\_\_init\_\_.py](https://app.codecov.io/gh/agrc/palletjack/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svX19pbml0X18ucHk=) | `80.00% <66.66%> (-20.00%)` | :arrow_down: | | [src/palletjack/transform.py](https://app.codecov.io/gh/agrc/palletjack/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agrc#diff-c3JjL3BhbGxldGphY2svdHJhbnNmb3JtLnB5) | `97.95% <100.00%> (+2.35%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.