agrc / palletjack

A library for updating AGOL data from various external sources
MIT License
12 stars 0 forks source link

Add customizable prefix to the uploaded gdb item's name #85

Closed jacobdadams closed 3 months ago

jacobdadams commented 3 months ago

load.FeatuerServiceUpdater._upload_gdb currently uploads the gdb as an item with the name "Temporary gdb upload." However, if this already exists due to not cleaning up a previous run or using this name for something else, the upload will fail and the update will bomb out. This can be a bad thing™, as sometimes existing data have already been truncated/deleted.

A parameterized prefix for this name allows the client app to set a unique name and then check for its existence prior to deleting any existing data.

Also a bunch of black/ruff updates.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.18996% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 94.52%. Comparing base (7152210) to head (9482b2d).

Files Patch % Lines
src/palletjack/extract.py 90.19% 7 Missing and 3 partials :warning:
src/palletjack/load.py 92.68% 5 Missing and 1 partial :warning:
src/palletjack/transform.py 94.73% 1 Missing :warning:
src/palletjack/utils.py 98.63% 0 Missing and 1 partial :warning:
src/palletjack/version.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #85 +/- ## ========================================== + Coverage 93.48% 94.52% +1.04% ========================================== Files 7 7 Lines 1135 1133 -2 Branches 148 148 ========================================== + Hits 1061 1071 +10 + Misses 64 52 -12 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.