agrc / porter

UGRC tracks the additions, replacements, and deletions of SGID items (in the broadest sense of add, replace, or delete) through issues in this repository.
https://gis.utah.gov/documentation/policy/
MIT License
2 stars 0 forks source link

Gracefully handle check initialization exceptions #101

Closed stdavis closed 3 years ago

stdavis commented 3 years ago

This was spurred by the table checks connection to the database which short-circuited the entire app. Here's what it would post with these changes if it was run today (without a connection to SGID/Internal):

comment below would be posted to issue: "Add combined Wilderness layer to SGID from BLM and USFS" in production

conductor results for tasks - 100

check status
@gregbunce has completed 0 out of 1 tasks :no_entry:
@steveoh has completed 0 out of 3 tasks :no_entry:
@rkelson has completed 0 out of 1 tasks :no_entry:
@ZachBeck has completed 2 out of 8 tasks :no_entry:
@jacobdadams has completed 0 out of 1 tasks :no_entry:

comment below would be posted to issue: "Add combined Wilderness layer to SGID from BLM and USFS" in production

conductor results for BOUNDARIES.UtahWildernessAreas

check status
internal sgid ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
sgid10 ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
meta table ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
stewardship 'NoneType' object has no attribute 'open_by_key'

comment below would be posted to issue: "Remove BOUNDARIES.USFSWilderness from SGID" in production

conductor results for tasks - 99

check status
@gregbunce has completed 0 out of 1 tasks :no_entry:
@steveoh has completed 0 out of 5 tasks :no_entry:
rkelson has completed 1 out of 1 tasks :+1:
@ZachBeck has completed 0 out of 10 tasks :no_entry:
@jacobdadams has completed 0 out of 1 tasks :no_entry:

comment below would be posted to issue: "Remove BOUNDARIES.USFSWilderness from SGID" in production

conductor results for BOUNDARIES.USFSWilderness

check status
internal sgid ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
sgid10 ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
meta table ('HYT00', '[HYT00] [Microsoft][ODBC Driver 17 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')
stewardship 'NoneType' object has no attribute 'open_by_key'

comment below would be posted to issue: "Add Utah Quaternary Faults from UGS replacing existing faults in AGOL" in production

conductor results for tasks - 75

check status
gregbunce has completed 2 out of 2 tasks :+1:
@steveoh has completed 1 out of 3 tasks :no_entry:
rkelson has completed 1 out of 1 tasks :+1:
@stdavis has completed 2 out of 3 tasks :no_entry:
@ZachBeck has completed 6 out of 7 tasks :no_entry:
@jacobdadams has completed 0 out of 1 tasks :no_entry:
codecov[bot] commented 3 years ago

Codecov Report

Merging #101 (30ceb55) into main (8657c59) will decrease coverage by 0.55%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   86.84%   86.29%   -0.56%     
==========================================
  Files           2        2              
  Lines         403      416      +13     
  Branches       70       70              
==========================================
+ Hits          350      359       +9     
- Misses         47       51       +4     
  Partials        6        6              
Impacted Files Coverage Δ
src/conductor/conductor.py 80.12% <83.33%> (-0.96%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8657c59...30ceb55. Read the comment docs.

stdavis commented 3 years ago

OK. I gave it a more generic error message and updated from main.