Closed steveoh closed 2 years ago
Merging #168 (110d14c) into main (3fdc435) will increase coverage by
4.48%
. The diff coverage is30.00%
.
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 86.65% 91.13% +4.48%
==========================================
Files 2 2
Lines 427 406 -21
Branches 72 76 +4
==========================================
Hits 370 370
+ Misses 51 29 -22
- Partials 6 7 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/conductor/conductor.py | 91.60% <25.00%> (+11.48%) |
:arrow_up: |
src/conductor/checks.py | 90.87% <33.33%> (+0.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 755d353...110d14c. Read the comment docs.
Looks good to me so far.
this goes along with the porter pull request in the terraform project.
This uses the gcp workload federation with github actions. Removes pub/sub and calls directly to cloud run Deploys cloud run and the scheduler in the action
on prem database access is timing out. I wonder if we don't have a firewall rule on the dev vpc. I think it should work in production.