agrc / porter

UGRC tracks the additions, replacements, and deletions of SGID items (in the broadest sense of add, replace, or delete) through issues in this repository.
https://gis.utah.gov/documentation/policy/
MIT License
2 stars 0 forks source link

fix: point at versioned view of meta table #169

Closed stdavis closed 2 years ago

stdavis commented 2 years ago

Otherwise, recent edits may not show up in the checks.

Ref: https://github.com/agrc/porter/issues/163#issuecomment-981845629

codecov[bot] commented 2 years ago

Codecov Report

Merging #169 (34a1341) into main (3fdc435) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files           2        2           
  Lines         427      427           
  Branches       72       81    +9     
=======================================
  Hits          370      370           
  Misses         51       51           
  Partials        6        6           
Impacted Files Coverage Δ
src/conductor/checks.py 90.60% <ø> (ø)
src/conductor/conductor.py 80.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 755d353...34a1341. Read the comment docs.

steveoh commented 2 years ago

This makes me think we are fixing a problem that shouldn't exist.

stdavis commented 2 years ago

This makes me think we are fixing a problem that shouldn't exist.

I'm guessing that there was a reason why we enabled versioning since it's something that we would have had to opt into. Perhaps for the editor tracking?