agreatdayy / pe

0 stars 0 forks source link

Delete Error Message #3

Open agreatdayy opened 5 months ago

agreatdayy commented 5 months ago

The error messages for delete function are not consistent.

For example, when the input is delete <negative integer or zero>, this error message is printed. Expected: image.png However, when the input is delete <positive but larger than list size>, a different error message is printed. Actual: image.png

The error message for when a positive integer larger than actual list size should be the same as the first error message above as it is more specific.

nus-se-script commented 5 months ago

Team's Response

The first command that you mentioned throws an error as the delete message is not in the correct format. It is stated in the output box that INDEX parameter must be a positive integer in the output window. The second command throws an error as the client index of 100 does not exist.

These two commands are throwing different errors as they are different cases of incorrect inputs.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The reasons provided by the team are valid, however I still think that negative integers and integers that do not exist are both considered as invalid inputs and entering a negative input is not considered as invalid command format. Thus, perhaps it would be clearer if the error message for invalid inputs could be something similar to the error message for invalid command format, and be more specific. For example, it could be something like:

Invalid INDEX input! delete: Deletes the client identified by the index number used in the displayed client list. Parameters: INDEX(must be a positive integer and exists in the list)

Suggested response: response.notInScope