Exp immutability improvements

agrestio / agrest

Server-side Java REST Framework for easy access to data graphs from various backends

https://agrest.io

Apache License 2.0

80 stars 34 forks source link

Exp immutability improvements #645

Closed andrus closed 11 months ago

andrus commented 1 year ago

After #602 , our expressions are outwardly immutable. Now we can tweak a few internals to make the API more clean, be consistent between parsed and manually-created expressions and avoid extensive "deepCopy" on assembly:

[ ] Remove SimpleNode.parent property (will require making SimpleNode.jjtSetParent() a noop). One step to avoid deep copy
[ ] Somehow "freeze" child changes. Final step to avoid deep copy.

andrus commented 11 months ago

Let's put this on hold. We have other things to work on.