search

agriffis / neovim

Nightly neovim rpms
https://arongriffis.com/2019/03/02/neovim-nightly-builds
Other
20 stars 0 forks source link

Fedora luajit version is not compatible with neovim #10

Open VikramNisarga opened 3 years ago

VikramNisarga commented 3 years ago

Fedora's luajit is using the build flag -DLUAJIT_ENABLE_LUA52COMPAT to build luajit, which changes the return type of some of the methods whereas the neovim's laujit version is not using this build flag. Because of this some of the neovim's plugins are not working in fedora 34

Steps to reproduce using nvim -u NORC

Execute :lua print(os.execute("mkdir ./test"))

Actual behaviour

returns true exit 0

Expected behaviour

0

agriffis commented 3 years ago

Hi, this repo is only for the COPR nightly builds. These builds are unofficial, they're not associated with either Neovim or Fedora upstreams, and I have no control over luajit.

Could you open a bug at https://bugzilla.redhat.com/ instead? It would be great to get this problem fixed.

VikramNisarga commented 3 years ago

Hi, this repo is only for the COPR nightly builds. These builds are unofficial, they're not associated with either Neovim or Fedora upstreams, and I have no control over luajit.

Could you open a bug at https://bugzilla.redhat.com/ instead? It would be great to get this problem fixed.

Hi, The issue is only with this copr build, neovim built from source or the appimage version works fine

agriffis commented 3 years ago

I think the appimage (and neovim built from source) bundles its own luajit.

Does Fedora's build of neovim have the problem? (Edit: yes it does)

agriffis commented 3 years ago

Here's the problem in Fedora: https://src.fedoraproject.org/rpms/luajit/c/1d64e7791a9d64bcd58ea7917242b2d481fc4857?branch=rawhide

Unfortunately it seems that Fedora has been building luajit like this for a while, so it will be harder to recommend a fix that doesn't break other software depending on luajit in Fedora. Depending on the extent of the breakage in Neovim plugins, it might be easier to update them instead.

Regardless, this is not something we can fix in the COPR build. Something will need to change in Fedora first.

agriffis commented 3 years ago

@ignatenkobrain Do you have any thoughts about this? The summary is that neovim depends on luajit without -DLUAJIT_ENABLE_LUA52COMPAT but Fedora started building with this flag a couple years ago. We could open a bugzilla but it's not clear to me what the path forward would be, even if we do that.

(This repo is just a COPR build of neovim nightly, but I verified the problem also appears in F34 neovim.)

agriffis commented 3 years ago

I'll reopen the issue, but only for tracking until we find a way to fix this elsewhere. There is nothing we can do in the COPR build.