search

agriggio / make_arq

A command-line tool for generating Sony A7RIII Pixel-Shift ARQ files
Other
23 stars 4 forks source link

python 3.9, 3.10 - green image #8

Closed bor-lin closed 1 year ago

bor-lin commented 1 year ago

Using python 3.9 or 3.10 images are green (something like demosaicing none on page https://rawpedia.rawtherapee.com/Demosaicing ).

With python 3.7 all looks good.

agriggio commented 1 year ago

Hi @bor-lin, what camera are you using? Can you provide sample files to reproduce? Thanks!

bor-lin commented 1 year ago

Hi, I'am using Sony a7r4. Where to put large files? Thanks

On Thu, May 18, 2023 at 10:39 AM Alberto Griggio @.***> wrote:

Hi @bor-lin https://github.com/bor-lin, what camera are you using? Can you provide sample files to reproduce? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1552730862, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5EUZNQBADT5P5RCR6TXGXN5VANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

abrock commented 1 year ago

Hi, I'am using Sony a7r4. Where to put large files? Thanks

You can use something like Google drive or Dropbox. I also have that camera model so I took a quick test shot and found the same problem:

https://drive.google.com/drive/folders/1AjZ2nIw6ewCgo48EgaHhyRhO524IyWId?usp=share_link

The problem is the same in full frame and APSC-crop so I only uploaded the APSC-crop images for now.

This is what I see in RT:

image

abrock commented 1 year ago

I'm using Python 3.9.2 on Debian Bullseye. I can try to install Python 3.7 if necessary.

bor-lin commented 1 year ago

Hi, Please find this file: https://drive.google.com/file/d/1Zq8kQY-q8sWhyEfdWzs1YClRo-diFKgR/view?usp=sharing Please let me know when Ican delete this file. I have done tests using an old one gento and make_arg and new. Thanks

On Thu, May 18, 2023 at 1:45 PM abrock @.***> wrote:

I'm using Python 3.9.2 on Debian Bullseye. I can try to install Python 3.7 if necessary.

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1552936067, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5C2UAL2NGQPMZ57ZS3XGYDUBANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

agriggio commented 1 year ago

Thanks for the samples. It turns out the problem is not a newer interpreter, but a newer version of the tifffile library. It should be fixed now, but it would be good if you could confirm. Thanks!

abrock commented 1 year ago

I can confirm that it works as expected with full frame and with APSC-crop. Thank you very much for this amazing software, it's very helpful.

agriggio commented 1 year ago

Great, closing then!

bor-lin commented 1 year ago

Thank you very much for adapting make_arq to the new tifffile. I've used make_arq for many years and have been having a lot of trouble with it recently. There is one more problem - a quarter of the image is displayed. Thank you again

On Thu, May 18, 2023 at 11:15 PM Alberto Griggio @.***> wrote:

Closed #8 https://github.com/agriggio/make_arq/issues/8 as completed.

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#event-9283852652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5CUZLCOXF55G4TXED3XG2GOHANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

abrock commented 1 year ago

There is one more problem - a quarter of the image is displayed. Thank you again

Could you upload the four images and also a screenshot showing the problem?

bor-lin commented 1 year ago

https://drive.google.com/file/d/1CHsUE9TzLgawcghRoWQqg91WLrILF8Ry/view?usp=sharing

I have attached this to the last e-mail but is not visible

On Fri, May 19, 2023 at 12:30 PM abrock @.***> wrote:

There is one more problem - a quarter of the image is displayed. Thank you again

Could you upload the four images and also a screenshot showing the problem?

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1554367984, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5BM44SZHUYD4BRYBO3XG5DVNANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

bor-lin commented 1 year ago

I have 16 ARW and one ARQ - do you need them?

On Fri, May 19, 2023 at 12:40 PM jj1234 bb1234 @.***> wrote:

https://drive.google.com/file/d/1CHsUE9TzLgawcghRoWQqg91WLrILF8Ry/view?usp=sharing

I have attached this to the last e-mail but is not visible

On Fri, May 19, 2023 at 12:30 PM abrock @.***> wrote:

There is one more problem - a quarter of the image is displayed. Thank you again

Could you upload the four images and also a screenshot showing the problem?

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1554367984, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5BM44SZHUYD4BRYBO3XG5DVNANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

bor-lin commented 1 year ago

16 ARW and ARQ made with yesterday make_arq

https://drive.google.com/file/d/1wHBWWARifEqfq8a1F6iGSC_Q9HuYOTFI/view?usp=sharing

Please let me know when Ican delete this file.

On Fri, May 19, 2023 at 12:43 PM jj1234 bb1234 @.***> wrote:

I have 16 ARW and one ARQ - do you need them?

On Fri, May 19, 2023 at 12:40 PM jj1234 bb1234 @.***> wrote:

https://drive.google.com/file/d/1CHsUE9TzLgawcghRoWQqg91WLrILF8Ry/view?usp=sharing

I have attached this to the last e-mail but is not visible

On Fri, May 19, 2023 at 12:30 PM abrock @.***> wrote:

There is one more problem - a quarter of the image is displayed. Thank you again

Could you upload the four images and also a screenshot showing the problem?

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1554367984, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5BM44SZHUYD4BRYBO3XG5DVNANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

abrock commented 1 year ago

I downloaded the files and I cannot reproduce the problem, if I run make_arq I get the full frame:

image

bor-lin commented 1 year ago

I have: dev-lang/python-3.9.16_p3 tifffile 2023.4.12

and I have " quarter problem"

On Fri, May 19, 2023 at 1:31 PM abrock @.***> wrote:

I downloaded the files and I cannot reproduce the problem, if I run make_arq I get the full frame:

[image: image] https://user-images.githubusercontent.com/31710/239520942-c175e6e3-46c8-4973-bf35-fed984c23144.png

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1554438044, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5G3TBEXVIJKMNQE373XG5KXVANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

bor-lin commented 1 year ago

I have tested:

  1. without mc (ctrl-o and command)
  2. without ls ... Result the same - "quarter".

With: python-3.9.0_beta5 tifffile 2023.4.12 (the same !!!)

and ls -l _makearq.c -rw-r--r-- 1 bor users 3518 Nov 25 2020 _makearq.c

there is full image.

On Fri, May 19, 2023 at 1:54 PM jj1234 bb1234 @.***> wrote:

I have: dev-lang/python-3.9.16_p3 tifffile 2023.4.12

and I have " quarter problem"

On Fri, May 19, 2023 at 1:31 PM abrock @.***> wrote:

I downloaded the files and I cannot reproduce the problem, if I run make_arq I get the full frame:

[image: image] https://user-images.githubusercontent.com/31710/239520942-c175e6e3-46c8-4973-bf35-fed984c23144.png

— Reply to this email directly, view it on GitHub https://github.com/agriggio/make_arq/issues/8#issuecomment-1554438044, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX7Z5G3TBEXVIJKMNQE373XG5KXVANCNFSM6AAAAAAXMJBLEU . You are receiving this because you were mentioned.Message ID: @.***>

agriggio commented 1 year ago

please open a separate issue, thanks!