search

agritheory / approvals

Customizable Approval Workflows
Other
4 stars 1 forks source link

Make Document Approval Rule sensitive to non-workflow situations #40

Open agritheory opened 1 month ago

agritheory commented 1 month ago

Where a workflow does not exist (Purchase Invoice in the current example set), and a document is submit-able, "Approve" should trigger a frappe.confirm about submitting the document, just as it normally would.

agritheory commented 1 month ago

@MyuddinKhatri I shouldn't have merged this, can you raise a PR with the additional Playwright changes? I think the CI needs an extra line

      - name: Run Tests
        working-directory: /home/runner/frappe-bench
        run: |
          source env/bin/activate
          cd apps/approvals
          poetry install
          playwright install --with-deps
          pytest --cov=approvals --cov-report=xml --disable-warnings -s | tee pytest-coverage.txt