search

agritheory / approvals

Customizable Approval Workflows
Other
4 stars 1 forks source link

Make Approved State in Workflow configurable #45

Open agritheory opened 2 months ago

agritheory commented 2 months ago

New custom field in workflow for Approval State

Refactor api.py/set_status_to_approved to not use a string literal for "Approved"

MyuddinKhatri commented 2 months ago

@agritheory I didn't find any usage for this method - set_status_to_approved in the codebase. should I change doc.status to match against approval_state instead of string literal?

agritheory commented 2 months ago

@MyuddinKhatri Yes or match Frappe's default "Submitted" if a document is submittable. It might also make sense to call doc.get_status if that exists. I will share an example client implementation of this privately.