Cancelled SLEs ignored by `get_handling_unit`

agritheory / beam

General Purpose 2D barcode scanning for ERPNext

https://agritheory.com/documentation/beam/

Other

20 stars 9 forks source link

Closed agritheory closed 9 months ago

agritheory commented 9 months ago

[x] Feature working, design validated
[x] (corrected net qty) Tests pass
- [x] There's a new overconsumption failure in another test, not sure if its related or is an artifact from a previous test
[x] Docs with screenshot of new cancellation workflow

agritheory commented 9 months ago

Discussion in #65 should be resolved before merging.

agritheory commented 9 months ago

@HKuz Can you take a look at this one? To test cancellation workflow I was setting up a transfer stock entry:

from beam.tests.test_handling_unit import *
test_stock_entry_material_transfer_for_manufacture()
frappe.db.commit()

I still need to add to the docs to show the new recombine/ cancellation workflow.

@Rgottsch1 I found the bug you were showing, the fix will be included when this is merged.

HKuz commented 9 months ago

@agritheory this looks good - two things I noticed, which may be by design but wanted to ask about:

for items where the entire quantity of the existing HU that are transferred, a new HU is being created (for the test example, the Limequat and Kaduka Lime both get new HUs on transfer)
after cancel, an item I opted to not recombine kept its HU as expected, but stayed in the Kitchen (wasn't sure if this should go back to the original WH, in this case the Refrigerator)

agritheory commented 9 months ago

@HKuz Ready for review

HKuz commented 9 months ago

@agritheory docs look good!