search

agritheory / beam

General Purpose 2D barcode scanning for ERPNext
https://agritheory.com/documentation/beam/
Other
20 stars 9 forks source link

ci: update release action user and email #68

Closed HKuz closed 9 months ago

HKuz commented 9 months ago

This PR updates the username and email in the Python Semantic Release GH action script. The default behavior was to use github-actions@github.com but because it isn't an actual account, it shows as 'Invalid email' / avatar in the repo when it's the latest commit.

The action script has read/write access, but the docs say the username/email need to be associated with the token used (for permissions). I see this as having two options for using the support@agritheory.dev email:

1) Add the email to the AgriTheory account (go to GitHub Settings -> Emails -> Add email address). I tested this on one of my repos using my associated AgriTheory dev email (vs primary gmail account) and it worked great 2) Create a separate GitHub account for the support email, give it read/write access to any repo we use it for in the GH action

⚠️ NOTE BEFORE MERGING ⚠️ - merging this PR will likely break the release workflow until the support email is (or is associated with) an actual GH account.

agritheory commented 9 months ago

@HKuz I associated the support address with my account. Merging.

HKuz commented 9 months ago

@agritheory awesome - I'll roll this change into the other repos as well