agritheory / check_run

Payables utility for ERPNext
https://agritheory.com/documentation/check_run/
Other
29 stars 26 forks source link

Print Preview Override #240

Closed agritheory closed 4 months ago

agritheory commented 5 months ago

211

This is probably not be a good enough solution as-is and more drastic measures I think are required, namely a partial override of frappe/www/printview.py

Screenshot ![image](https://github.com/agritheory/check_run/assets/18033666/eae0cd6e-3548-47e3-a316-8d2047488198)

There should be three checks/ Payment Entries in this Check Run, only one renders on the preview page due to the inclusion of page break HTML. It's likely that a better technique for previewing page breaks will be required.

Given that one cannot render the Payment Entries of the Check Run until it is submitted, I think it makes sense to return nothing or an error message in that case.

It would also be preferable to have a dedicated page to preview the Check Run and handle that with specific route rules instead of overriding the print preview. This would give greater control of the configuration of the printing, including showing important options like starting check number, etc.