feat: allow attachments with Amazon S3

agritheory / cloud_storage

S3 protocol storage for Frappe Applications - compatible with S3, Backblaze and DO Spaces

https://agritheory.com/documentation/cloud_storage

Other

9 stars 4 forks source link

feat: allow attachments with Amazon S3 #1

Closed Alchez closed 1 year ago

Alchez commented 1 year ago

Includes CI changes and closes #2

agritheory commented 1 year ago

You need a cloud_storage.bundle.js for the overrides.js file to work: https://github.com/frappe/frappe/wiki/Migrating-to-Version-14#new-build-system-based-on-esbuild

[x] Add Types
[x] Readme (copy/modify Check Run)
[x] docs/index.md with production configuration instructions
[x] docs/contributing.md with developer setup instructions
[x] docs/decisions using madr

Next step is unit tests and a mock, but we'll make that part of a PR with more CI tooling

Alchez commented 1 year ago

@agritheory, I'm not sure how to use or fix rob's JSON diff tool here. It's rightly seeing that package.json got added, but technically that shouldn't fail.

agritheory commented 1 year ago

@Alchez It's OK to for it to fail, because that's a signal that "schema has changed". Though we need a way to add an "approve" step to it.