fix: recursion bug while adding file associations

agritheory / cloud_storage

S3 protocol storage for Frappe Applications - compatible with S3, Backblaze and DO Spaces

https://agritheory.com/documentation/cloud_storage

Other

12 stars 7 forks source link

fix: recursion bug while adding file associations #33

Closed Alchez closed 1 year ago

Alchez commented 1 year ago

Changes:

When adding associations to a file without a content hash, the code would run into a maximum-recursion error. Adding a couple of checks to avoid this behaviour.
Changed a field label (S3_key -> S3 Key)

agritheory commented 1 year ago

@Alchez What does a test for this look like?

Alchez commented 1 year ago

@agritheory, here's what I tried locally to replicate:

Open a file that:
- has the cloud_storage app's file URL format
- has empty content_hash data (not sure why this is empty though)
Manually add a file association to the table and save (see maximum-recursion error)

Alchez commented 1 year ago

@agritheory, I added changes to the existing file association test. And I'm able to replicate the error in pytest without the new code, and a success with it.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 14.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: