Closed MyuddinKhatri closed 1 month ago
@agritheory I have added version from init.py, as it is required for package mode, the versioning can be made dynamic with these -
I would like to know your thought should we add these or keep version as it is in pyproject.toml?
@MyuddinKhatri How is this different (in outcome) from how we've implemented python semantic version?
@MyuddinKhatri How is this different (in outcome) from how we've implemented python semantic version?
@agritheory I got confused between the existing dynamic = ["version"] via flit_core, I wanted to include version in current pyproject.toml with poetry as version is mandatory, and I wanted to do something similar to this, but forgot about the python semantic version.
@MyuddinKhatri Can you fix the linting here?
@MyuddinKhatri Can you fix the linting here?
Sure, I'll look into it why linting is failing.
@MyuddinKhatri I recognize the problem and just pushed a fix
Issue - https://github.com/agritheory/cloud_storage/issues/61
Changes collected in test_utils test_utils