agritheory / cloud_storage

S3 protocol storage for Frappe Applications - compatible with S3, Backblaze and DO Spaces
https://agritheory.com/documentation/cloud_storage
Other
9 stars 4 forks source link

refactor: pyproject.toml to poetry #65

Closed MyuddinKhatri closed 1 month ago

MyuddinKhatri commented 2 months ago

Issue - https://github.com/agritheory/cloud_storage/issues/61

Changes collected in test_utils test_utils

MyuddinKhatri commented 2 months ago

@agritheory I have added version from init.py, as it is required for package mode, the versioning can be made dynamic with these -

I would like to know your thought should we add these or keep version as it is in pyproject.toml?

agritheory commented 2 months ago

@MyuddinKhatri How is this different (in outcome) from how we've implemented python semantic version?

MyuddinKhatri commented 2 months ago

@MyuddinKhatri How is this different (in outcome) from how we've implemented python semantic version?

@agritheory I got confused between the existing dynamic = ["version"] via flit_core, I wanted to include version in current pyproject.toml with poetry as version is mandatory, and I wanted to do something similar to this, but forgot about the python semantic version.

agritheory commented 1 month ago

@MyuddinKhatri Can you fix the linting here?

MyuddinKhatri commented 1 month ago

@MyuddinKhatri Can you fix the linting here?

Sure, I'll look into it why linting is failing.

agritheory commented 1 month ago

@MyuddinKhatri I recognize the problem and just pushed a fix