feat: pre-commit configs from test_utils

agritheory / cloud_storage

S3 protocol storage for Frappe Applications - compatible with S3, Backblaze and DO Spaces

https://agritheory.com/documentation/cloud_storage

Other

9 stars 4 forks source link

feat: pre-commit configs from test_utils #71

Closed MyuddinKhatri closed 1 week ago

MyuddinKhatri commented 1 week ago

Issue - #68

Added pre-commit config from test_utils -

validate_copyright
clean_customized_doctypes
validate_customizations
validate_python_dependencies
validate_javascript_dependencies

agritheory commented 1 week ago

@MyuddinKhatri This coverage test failure doesn't really make sense, what's going on?

MyuddinKhatri commented 1 week ago

@MyuddinKhatri This coverage test failure doesn't really make sense, what's going on?

@agritheory I looked into it, getting this same on inventory tools, tried it on my fork for inventory_tools, and it added the coverage comment correctly, I read a thread that says we need to check Read and write permissions under repository Settings > Actions > General > Select "Read and Write" under "Workflow Permissions". Can you please check this?

Alchez commented 1 week ago

@MyuddinKhatri can you try adding the following snippet to the Frappe workflow and see if that works? (based on this)

permissions:
  contents: write
  checks: write
  pull-requests: write