Closed Alchez closed 4 months ago
@Alchez I think it's correct to include them. One of them needs a re-review and there's an issue with the pytest action on all the cherry-picked commits that we need to resolve.
Thanks for doing this @Alchez - the purchase cycle commits all looked good 👍
there's an issue with the pytest action on all the cherry-picked commits that we need to resolve.
@agritheory seems like an issue where the tests expect the job cards to be submitted, but the test setup isn't setting it up. Not sure if this is a v15 issue, but I can look into it.
Update: version-14 used to create time_logs
for Job Cards, but they've since separated scheduled time from actual time.
@fproldan It appears I am not using the track overrides feature correctly, can you offer some guidance. These a lot of extra noise in this PR, trying to get all the pre-commit processes to work.
Coverage Report
File Stmts Miss Cover Missing inventory_tools __init__.py 5 0 100% customize.py 24 24 0% 4–47 hooks.py 17 0 100% inventory_tools/inventory_tools __init__.py 0 0 100% boot.py 6 6 0% 1–8 inventory_tools/inventory_tools/doctype __init__.py 0 0 100% inventory_tools/inventory_tools/doctype/inventory_tools_settings __init__.py 0 0 100% inventory_tools_settings.py 59 35 41% 16–17, 24–45, 60–65, 73–78, 85–91 test_inventory_tools_settings.py 3 0 100% inventory_tools/inventory_tools/doctype/purchase_invoice_subcontracting_detail __init__.py 0 0 100% purchase_invoice_subcontracting_detail.py 3 3 0% 5–9 inventory_tools/inventory_tools/doctype/purchase_order_subcontracting_detail __init__.py 0 0 100% purchase_order_subcontracting_detail.py 3 0 100% inventory_tools/inventory_tools/doctype/subcontracting_default __init__.py 0 0 100% subcontracting_default.py 3 3 0% 5–9 inventory_tools/inventory_tools/overrides job_card.py 17 2 88% 25, 32 purchase_order.py 148 100 32% 22, 81–84, 93–101, 112–131, 136–154, 159–222, 234–240, 253, 262–264, 269–274 sales_order.py 24 1 96% 46 stock_entry.py 77 19 75% 77–78, 81, 87, 96, 104, 162, 168, 172, 179–199 uom.py 61 15 75% 11–23, 44–45, 84, 91, 109–114 warehouse.py 43 16 63% 12, 17, 36–37, 40, 54–68 work_order.py 251 208 17% 26–29, 32–37, 40–42, 45–46, 49–50, 57–58, 65–93, 102–112, 125–158, 175, 178–181, 191–232, 240–270, 276–289, 293–316, 320–357, 365–380, 385–471, 476–498, 512 inventory_tools/inventory_tools/report __init__.py 0 0 100% inventory_tools/inventory_tools/report/manufacturing_capacity __init__.py 0 0 100% manufacturing_capacity.py 80 55 31% 11–12, 16, 84–115, 127–133, 214–296, 311–316, 324–338 inventory_tools/inventory_tools/report/material_demand __init__.py 0 0 100% material_demand.py 148 9 94% 18, 207–208, 227, 240, 248, 258, 274, 315 inventory_tools/inventory_tools/report/quotation_demand __init__.py 0 0 100% quotation_demand.py 64 4 94% 14, 48, 164, 185 inventory_tools/tests conftest.py 24 2 92% 29–30 test_manufacturing_capacity.py 50 0 100% test_material_demand.py 117 8 93% 47, 92, 129, 136–138, 185, 233 test_overproduction.py 93 0 100% test_quotation_demand_report.py 71 1 99% 43 test_uom.py 15 0 100% test_warehouse_path.py 12 0 100% TOTAL 1418 511 64%
@agritheory A couple functions had additions between v14 and v15 that I've added into this PR, but I'm not sure if they should stay out. Let me know.