agritheory / shipstation_integration

Other
6 stars 6 forks source link

feat: sync tagId name and color #19

Closed bhattdevarsh closed 3 weeks ago

bhattdevarsh commented 5 months ago

Todo:

bhattdevarsh commented 5 months ago

I am trying to update the tag colors using Frappe pallet but the response is buggy and requires dom manipulation, hence I have not added it to the base commit.

bhattdevarsh commented 5 months ago

while Implementing the coloring of tags, I came across following questions:

  1. The color hex that is synced from shipstation is and where as Frappe UI expect 2 (BG, Text) colors. If we ignore text color there are high chances we lose readability of the tags as the BG color can be anything.
  2. If there is a case where user creates tags on the fly, what should be the color?
  3. There is valid reason why Frappe is using fix set of color pallet(Most likely to avoid first two points) if we override the pallet or propose change to frappe may not be viable solution.