search

agritheory / shipstation_integration

Other
4 stars 3 forks source link

fix: move custom fields to JSON #23

Open Alchez opened 3 months ago

Alchez commented 3 months ago

Closes #2.

Alchez commented 3 months ago

@agritheory I've added the validate_customizations pre-commit hook, which also setup the module name in the JSON files.

agritheory commented 3 months ago

@Alchez We can't run a pre-commit that is expecting a complete Frappe environment unless we build that environment.

Alchez commented 3 months ago

@agritheory makes sense. For this repo, I've skipped the validate_customizations in the default linter CI workflow, and instead added it to the Frappe CI workflow.

But the test is still failing and I had created a ticket over at https://github.com/agritheory/test_utils/issues/54 for the error. I think we'll have to update and document this further.

CC: @MyuddinKhatri