search

agritheory / shipstation_integration

Other
6 stars 6 forks source link

feat: so status, docstatus mapping #42

Open batonac opened 2 months ago

batonac commented 2 months ago

My thoughts on how fix #41

batonac commented 1 month ago

Hey @Alchez @agritheory anything I can do to drive this forward?

batonac commented 2 weeks ago

Any more thoughts on how to move this along at this point?

agritheory commented 2 weeks ago

I have mixed feeling about this being the default behavior for this integration. In terms of using Shipstation via API, there are two main paths that this project currently allows:

  1. Orders from flow from marketplace(s) into Sales Orders with shipping data created or pre-positioned and ERPNext is largely a way to add financial/ ERP features the Shipstation workflow.
  2. ERPNext is the center of truth. Orders are created in ERPNext and shipping data (labels, etc) is created via API. This pull request is at odds with this workflow or a workflow that is a combination of these two, where SS import orders but orders are also created manually. While it is possible to build a two way sync that would satisfy both, I imagine it would be specific to the customer.
  3. Accepting this PR would break the workflow for at least one current customer.
batonac commented 2 weeks ago

got it @agritheory. If this was refactored to provide both two-way sync and opt-in configurability--ensuring that no existing behavior is altered by default--would you be in favor, or should I just maintain my own client-specific hooks/customizations around this?

agritheory commented 2 weeks ago

@batonac Yes, I think a checkbox at the ShipStation Settings level that would indicate a "force match" to ShipStation status would be the best way to opt into this.