agritheory / test_utils

Common Test Utilities and Fixtures for AgriTheory Projects
2 stars 3 forks source link

feat: added clean customization pre-commit config #24

Closed MyuddinKhatri closed 2 months ago

MyuddinKhatri commented 2 months ago

Added clean customization pre-commit config. Issue - https://github.com/agritheory/test_utils/issues/5

While adding a hook to pre-commit in other repos, pass the app name to entry in the hook. entry: python3 pre-commit/clean_customized_doctypes.py {app_name} replace app_name with actual app name. eg. entry: python3 pre-commit/clean_customized_doctypes.py cloud_storage

MyuddinKhatri commented 2 months ago

@agritheory Should we update modified in the json as well and remind to do a bench migrate?

agritheory commented 2 months ago

@MyuddinKhatri Yes, I think a modified timestamp makes sense. I don't know that we need to remind to do a bench migrate, it should be fine for most workflows I can think of

MyuddinKhatri commented 2 months ago

@MyuddinKhatri Yes, I think a modified timestamp makes sense. I don't know that we need to remind to do a bench migrate, it should be fine for most workflows I can think of

Okay, I pushed the changes that updates modified timestamp